add support for regular layouts and HOA output #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjnixon
force-pushed
the
regular_layouts
branch
from
cc25604 to
5a35651
Compare
tomjnixon
changed the title
this was more complicated than it needed to be for the current usage, and makes it difficult to make structures where the set of options is more dynamic all the options should be the same; the only API change is the removal of the actual options structures
layout-like objects may not have a use for a list of channels, so this is easier to generalise
just the ones needed; converting all uses would be a lot of pointless changes
tomjnixon
force-pushed
the
regular_layouts
branch
from
c2b3a55 to
95e0202
Compare
- extract convolver matrix - put the samples in the last axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular layouts
These currently have to be added to
ear/core/data/2051_layouts.yaml-- see this for example.I don't want to add these to the repository as I don't think there's a standard channel format, but i'd consider adding a CLI option to read them from a file.
HOA output
This should work well for DirectSpeakers, HOA and Objects input, provided extent and diffuse parameters are not used. These are implemented, but I need to look again at the decorrelation filters and extent behavior
HOA output can be enabled by passing something like
-s ambix_2for 2nd order ambix output -- seeear-render --helpfor details.Todo: