tidy variant checks #195
Open
tidy variant checks #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjnixon
force-pushed
the
tidy_variant_checks
branch
from
2e847d3 to
9f0bdb2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 125 125
Lines 5812 5812
=======================================
Hits 5226 5226
Misses 586 586 ☔ View full report in Codecov by Sentry. |
tomjnixon
force-pushed
the
tidy_variant_checks
branch
from
9f0bdb2 to
aaf0c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #191
Perhaps this should be called
isVariantTypeinstead? It's nice if the name of this matchesstd::holds_alternativewhich will eventually replace this.Code size changes are not dramatic, but every little helps.