Fix insert modal collapse: add Default option#368
Merged
Conversation
The "Make Collapsible" dropdown in the Insert Admonition/Callout modal had inverted logic: it only wrote the collapse parameter when the value *differed* from the configured default, meaning the selected value was never written when left at the default. Add a "Default" option (meaning: write nothing, let Obsidian or the plugin's global setting decide). The modal now initializes to the configured default collapse type when "Collapsible By Default" is on, or "Default" otherwise. Insertion logic simplifies to: write the value for any explicit selection (Open/Closed/None), skip it for "Default". Also documents the collapse behavior for both callout and code block formats in docs/commands.md. Fixes #335 Closes #357 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
collapse !== "default"comparison in both code block and callout insertion handlers"default"instead of conditionally choosing between the default collapse type or "none"Type
🐛 Bug fix, 🎨 Code cleanup