Modernize settings and fix esbuild symlink handling#374
Merged
Conversation
- Replace <details>/<summary>/collapser pattern with setHeading() sections - Remove open state persistence (plugin.data.open) from settings - Remove redundant h2 title and empty setting spacer in icon packs - Collapse 3 info paragraphs into heading descEl in Additional Syntaxes - Bump obsidian dep and minAppVersion to 1.11.0
esbuild's internal mkdir fails when outdir is an existing symlink. Detect symlinks, pre-create the real target directory, and pass the resolved path so builds work with a symlinked test vault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
<details>elements in favor of simple divs with heading settingsopensettings object that tracked expanded/collapsed state of settings sectionsopenfield from AdmonitionSettings interface