feat(slider): Adding slider vanilla component - FRONT-4252 #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
Feb 26, 2024
| slider.init(); | ||
|
|
||
| It comes with two variants, or actually only one, the default is to slide between items like `cards`, all the slides get the same width and a certain number of items will be visible in relation to the available space. | ||
| The variant is `tags` and can be used to slide in a list of `ecl tags`, or even better an `ecl tag set`, this variant would also work with simple links or buttons, elements that gets their width determined by the text that they contain. |
There was a problem hiding this comment.
just a remark here: if the variant 'tags' can be used for things like buttons and links, we could use a more generic name for it
| } | ||
|
|
||
| .ecl-slider__info { | ||
| display: none; |
There was a problem hiding this comment.
this seems to be overriden by javascript
| } | ||
|
|
||
| /** | ||
| * Static method to create an svg icon. |
There was a problem hiding this comment.
shouldn't we put this in the DOM utils?
…nent-library into FRONT-4252-Slider
…y into FRONT-4252-Slider
…y into FRONT-4252-Slider
…y into FRONT-4252-Slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.