Skip to content

Conversation

@chunkitmax
Copy link
Collaborator

@chunkitmax chunkitmax commented Jan 13, 2026

  • add back operations for attestation, preattestation and attestation_with_dal to the list of operations
  • make BLSModePreattestation and BLSModeAttestation consensus operations
  • exclude consensus operations from the results of ListOperations

@chunkitmax chunkitmax changed the title Update list operations Update ListOperations Jan 13, 2026
@jevonearth jevonearth requested a review from e-asphyx January 13, 2026 18:55
Copy link
Contributor

@e-asphyx e-asphyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove them in the first place?

Copy link
Contributor

@e-asphyx e-asphyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain please?

@chunkitmax
Copy link
Collaborator Author

I have not got any reply from this message I sent you 3 month ago.

My understanding is that those removed operations should be consensus operations instead of generic operations according to the source code.
`Attestation`, `AttestationWithDAL`, `BLSModeAttestation` are already under `AttestationSignRequest` which is `ConsensusSignRequest[AttestationRequestContent]`
`Preattestation` , `BLSModePreattestation` are already under `PreattestationSignRequest` which is `ConsensusSignRequest[PreattestationRequestContent]`

If the `OperationContents` is just listing all the operations, then `GenericOperationSignRequest` should not use it and instead maybe create a new enum for generic operations. 
That is the reason why there are duplicated attestation and preattestation operations on different levels in signatory config file which confuses users. If so, please revert it and advise.

But now I understand that OperationContents is really just a list of all operations after looking at the decoding path of the mempool. In order to avoid changing GenericOperationSignRequest, I would rather filter out consensus operations from the results of ListOperations.

All those changes were made for this ecadlabs/signatory#657

@chunkitmax
Copy link
Collaborator Author

Addressed by f8ffdc1

@chunkitmax chunkitmax closed this Jan 15, 2026
@chunkitmax chunkitmax deleted the update-list-operations branch January 15, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants