-
Notifications
You must be signed in to change notification settings - Fork 56
MaterialItem.MaterialList is nullable #7217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaterialItem.MaterialList is nullable #7217
Conversation
105de4f
to
57bb82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is it expected to be null?
thx. |
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following api tests would be nice:
CreateActivityTest:
copy an activity from another camp -> materiallist is null
copy an activity from another camp, and then copy it again in the same camp
copy an activity from another camp, and then copy it to a third camp
@@ -151,9 +151,9 @@ public function testPatchMaterialItemValidatesMissingMaterialList() { | |||
'materialList' => null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following test would be nice:
update a materialitem with a null material list
-> if you set the materiallist to not null -> success
-> if you change another property and leave the materiallist null -> error
-> if you change the material list from null to a material list of another camp -> error
I see, so this is an improvement for e.g. copying activities with material from one camp to another. |
302ba27
to
56f99e6
Compare
No description provided.