Add support for simplifications based on symmetry#160
Merged
Conversation
Merge pull request #136 from ecboghiu/devel
Merge pull request #138 from ecboghiu/update-website
Update intro to be the same as in the documentation
Update README.md
Fix print of scenario information for hybrid scenarios
Upate to v2.0.1
Update the documentation website to v2.0.1
Update the documentation website to v2.0.1
…at InflationProblem level)
We see that the error stems from [A^{1,1}, B^{2,2}] which factorizes being indistinguishable from [A^{1,1}, A^{2,2}], despite this not following directly from symmetry. Perhaps a feature, not a bug.
…h are equal only after accounting for factorization.
…ful symmetries. Currently experience a bug in sdp_utils that should have been fixed...
…onomials, which is not used in practice.
…ing outcome relabelling.
…d outcome-relabelling symmetry assumptions (which essentially define a unique nonclassical distribution)
…RST outcome in CG notation.
…omatic symmetry discovery utilities.
…metries. Looks good!
…DP even when outcome relabelling symmetries are present
…y array which is actual less efficient for iteration. Fixed issue caused by prior commit #0317f943a562f2ec7669a16030d02b2c584ac86f
…terrupted with a function definition)
…tors coming from outcome relabelling (and private setting relabelling)
ALL TESTS PASS
This simplifies the code and reduces points of failure
This completes 51f3cb6
In this way we just compute it once. It is useful if we consider creating a single InflationProblem and recycling it for different symmetries
This is a function that is pretty standalone, and does not need to be inside InflationProblem
This has made me realize that lexorder is different in InflationLP and InflationSDP. We may want to correct this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the (optional) exploitation of symmetries in the target distribution for variable reduction. The most important additions are
InflationProblem.add_symmetries()to add custom symmetries expressed as permutations of the lexicographical order, andsymmetry_utilsfor helper functions. Documentation and tests are ready.