Conversation
…at InflationProblem level)
We see that the error stems from [A^{1,1}, B^{2,2}] which factorizes being indistinguishable from [A^{1,1}, A^{2,2}], despite this not following directly from symmetry. Perhaps a feature, not a bug.
…h are equal only after accounting for factorization.
…ful symmetries. Currently experience a bug in sdp_utils that should have been fixed...
…onomials, which is not used in practice.
…ing outcome relabelling.
…d outcome-relabelling symmetry assumptions (which essentially define a unique nonclassical distribution)
…RST outcome in CG notation.
…omatic symmetry discovery utilities.
…metries. Looks good!
…DP even when outcome relabelling symmetries are present
…y array which is actual less efficient for iteration. Fixed issue caused by prior commit #0317f943a562f2ec7669a16030d02b2c584ac86f
…) to act directly on lexorder, and only then convert to implied original events permutation. Extra care is now taken with setting relabelling, to stick to private settings only.
# Conflicts: # test/test_functions.py
…terrupted with a function definition)
…tors coming from outcome relabelling (and private setting relabelling)
ALL TESTS PASS
…ently used for logical indexing.
…easily-obtained properties of InflationSDP
…do-conditional if, at a minimum, all the operators commute.
…variable bounds (such as when default_non_negative=True) This resolves Issue #169
The measurements were already being created in InflationProblem
Hopefully this will prevent errors from happening during CI tests
Dualization is now entirely a suggested parameter for Mosek.
So that it solves correctly
… supress warning message)
Since every atom is already lexicographically minimized with respect to its dagger when real_qt=True, there is no need to assess if we should replace a compound monomial by its conjugate in that case. (When all operators commute, each atom is equal to its own dagger.)
On Python 3.11 networkx complains of using GraphMatcher on directed graphs since version 3.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update brings:
Also, we have the following improvements:
InflationSDP.build_columnscan be now directly passed ontoInflationSDP.generate_relaxation. This means that one can now build directly SDPs for restricted generating sets just by calling, e.g.,InflationSDP.generate_relaxation("local3", max_monomial_length=2).As well as minor fixes. On particularly useful one is that now the output status of LPs and SDPs is now the same.