fix: Parse Error in iOS Version Bumping #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found errors in utilizing
pbxproj-domif the iOS native files contained any code that was not properly escaped. Recently another developer created a forked version of that project since their pull request was not merged into pbxproj-dom.This PR addresses that parsing error by moving to the newly forked dependency. Previous to these changes I was patching the expo-modules-autolinking project, however after latest update, this no longer works without further change, wanted to resolve the root problem.
Tested this in my github actions by referencing my forked version.
Reference for more details: NativeScript/pbxproj-dom#10
Error prior to fork:
Successul Run from my fork:
