Skip to content

fix(core): Return ErrorResponse when disabled plugins are used #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix(core): Return ErrorResponse when disabled plugins are used #2703

merged 1 commit into from
May 13, 2025

Conversation

mnonnenmacher
Copy link
Contributor

This aligns the error response with other endpoints.

@mnonnenmacher
fix(core): Return ErrorResponse when disabled plugins are used
b738293 
This aligns the error response with other endpoints.

Fixes #2668.

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher force-pushed the disabled-plugins-error-response branch from bcf402b to b738293 Compare May 12, 2025 18:32
@mnonnenmacher mnonnenmacher marked this pull request as draft May 12, 2025 18:32
@github-actions GitHub Actions
Copy link

Issues referenced in commit messages and issues linked to this PR are not in sync.
Please manually link this PR to the following issues: 2668

@mnonnenmacher mnonnenmacher linked an issue May 12, 2025 that may be closed by this pull request
Some endpoints do not return error message and cause #2668
Closed
@mnonnenmacher mnonnenmacher mentioned this pull request May 12, 2025
Closed
@Etsija
Copy link
Contributor

Etsija commented May 13, 2025

I verified this by

  • disabling the PDF reporter plugin
  • trying to create a run for a repository, using the "ORT PDF Reports" option in the Reporters section
  • now the error message and cause are shown properly:

Screenshot from 2025-05-13 06-55-47

The PR seems to fix #2668 (at least from this part; there might still be some endpoints which do not return ErrorResponse properly).

@mnonnenmacher mnonnenmacher marked this pull request as ready for review May 13, 2025 07:17
@mnonnenmacher mnonnenmacher enabled auto-merge May 13, 2025 07:17
@mnonnenmacher
Copy link
Contributor Author

The PR seems to fix #2668 (at least from this part; there might still be some endpoints which do not return ErrorResponse properly).

Thanks for checking, I went through the code, all other endpoints should be fine.

@mnonnenmacher mnonnenmacher added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 821fc47 May 13, 2025
30 checks passed
@mnonnenmacher mnonnenmacher deleted the disabled-plugins-error-response branch May 13, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschuberth sschuberth sschuberth approved these changes

@bs-ondem bs-ondem Awaiting requested review from bs-ondem bs-ondem is a code owner

@MarcelBochtler MarcelBochtler Awaiting requested review from MarcelBochtler MarcelBochtler is a code owner

@nnobelis nnobelis Awaiting requested review from nnobelis nnobelis is a code owner

@oheger-bosch oheger-bosch Awaiting requested review from oheger-bosch oheger-bosch is a code owner

@wkl3nk wkl3nk Awaiting requested review from wkl3nk wkl3nk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some endpoints do not return error message and cause
3 participants
@mnonnenmacher @Etsija @sschuberth