Gradle chores #4123
Open
Gradle chores #4123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automate adding the "-service" suffix to service projects to reduce the manual maintenance effort. Signed-off-by: Martin Nonnenmacher <[email protected]>
Automate adding the parent project name as a prefix to SPI projects to reduce the manual maintenace effort. Signed-off-by: Martin Nonnenmacher <[email protected]>
Before, only the `config-worker` project had the "-worker" suffix, add it to all workers for consistency. Signed-off-by: Martin Nonnenmacher <[email protected]>
Add the component name as a prefix to the names of all subprojects. This ensures that all subprojects and their generated JAR files have unique names. Fixes #4087. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
requested review from
MarcelBochtler,
bs-ondem,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
|
Issues referenced in commit messages and issues linked to this PR are not in sync. |
sschuberth
reviewed
Dec 10, 2025
| // Append "-service" to all service project names. | ||
| rootProject.children.single { it.name == "services" }.children.forEach { it.name = "${it.name}-service" } | ||
|
|
||
| // Append "-worker" to all worker project names. |
Contributor
There was a problem hiding this comment.
Isn't this a breaking changes as it also changes the names of some published artifacts, I guess?
sschuberth
reviewed
Dec 10, 2025
| commonMain { | ||
| dependencies { | ||
| api(projects.components.infrastructureServices.apiModel) | ||
| api(projects.components.infrastructureServices.infrastructureServicesApiModel) |
Contributor
There was a problem hiding this comment.
Same here, isn't this a breaking change for consumers of the published artifacts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.