Open
Conversation
Contributor
|
Is this patch still viable for making it in? I don't see anyone having reviewed it yet. |
Contributor
|
it has not been reviewed yet indeed. based on the description, it still needs a bit of work on the block version selection before being merged. |
Contributor
Author
|
@divarvel It's been a while since I worked on this code, but I'm looking forward to your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements several v4 format features:
Along the way I solved several bugs and added some unit tests.
Since this is a very large PR, I suggest to review it commit by commit.
Also, since it still doesn't implement all of the v4 format, please merge it into a separate branch for now.
Lastly, just like #142, this implementation does not minimize the version number when serializing. I need your help in understanding the relevant code.