Signer interface definition and implementation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Korbik
force-pushed
the
remote_signer_2
branch
from
7e2c923 to
1d288a7
Compare
divarvel
reviewed
Feb 17, 2025
There was a problem hiding this comment.
overall LGTM, i indeed think that making KeyPair a subtype of Signer and not the other way around is the right modeling.
I have left a few questions / comments, most of them not blocking, except the one about root key ids in UnverifiedBiscuit.
A few other things look fishy, but are not strictly related to this PR
src/main/java/org/biscuitsec/biscuit/token/UnverifiedBiscuit.java
Outdated
Show resolved
Hide resolved
Korbik
force-pushed
the
remote_signer_2
branch
from
1d288a7 to
feed47c
Compare
Korbik
force-pushed
the
remote_signer_2
branch
from
feed47c to
fddf7a3
Compare
divarvel
approved these changes
Mar 3, 2025
|
Looks great, sorry for the late look; have been travelling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.