Skip to content

Java checkstyle google format migration #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Mar 18, 2025
Merged

Java checkstyle google format migration #116

merged 46 commits into from
Mar 18, 2025

Conversation

Korbik
Copy link
Contributor

@Korbik Korbik commented Mar 4, 2025 •
edited
Loading

Implementation of #110

Mix of sun_checks and Google Format

@Korbik Korbik marked this pull request as draft March 4, 2025 16:58
@Korbik Korbik mentioned this pull request Mar 4, 2025
Open
@KannarFr
Copy link
Contributor

KannarFr commented Mar 4, 2025

<3.

@Korbik Korbik marked this pull request as ready for review March 5, 2025 16:40
@ghubstan ghubstan mentioned this pull request Mar 7, 2025
Merged
ghubstan
ghubstan reviewed Mar 7, 2025
View reviewed changes
Copy link

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see customizations of the checkstyle.xml, and take back everything I said about renaming this file google_checks.xml.

Korbik added 26 commits March 18, 2025 06:38
@Korbik
Checkstyle: design: VisibilityModifier
0ce34dc
@Korbik
Checkstyle: coding: MissingSwitchDefault
995f291
@Korbik
Checkstyle: whitespace cleanup
0e26dc2
@Korbik
Checkstyle: whitespace: EmptyForIteratorPad
007f1ff
@Korbik
Checkstyle: whitespace: OperatorWrap
85e7691
@Korbik
Checkstyle: whitespace: WhitespaceAfter
6d821c7
@Korbik
Checkstyle: whitespace
c669048
@Korbik
Checkstyle: blocks: NeedBraces
405b54a
@Korbik
Spotless Google Format application
ad20f5c
@Korbik
Checkstyle: DistanceVariable Token
6d8670d
@Korbik
Checkstyle: DistanteVariable Scope:getPublicKey
90b6756
@Korbik
Checkstyle: DistanceVariable LogicError
a95555b
@Korbik
Checkstyle: DistanceVariable Authorizer
450c010
@Korbik
Checkstyle: DistanceVariable without Biscuit and Block
2e07758
@Korbik
Checkstyle: VariableDeclarationUsageDistance
1719c64
@Korbik
Checkstyle: naming: MethodName
2b8ab02
@Korbik
Checkstyle: naming: LambdaParameterName
fb3c0b4
@Korbik
Checkstyle: coding: ConstructorsDeclarationGrouping
5f0495e
@Korbik
Checkstyle: coding: VariableDeclarationUsageDistance
5ae94c4
@Korbik
Checkstyle: regexp: RegexpSinglelineJava
56a505e
@Korbik
Checkstyle: naming: LambdaParameterName
1c495ab
@Korbik
Checkstyle: naming: LocalVariableName
63eae7d
@Korbik
Checkstyle: naming: MemberName
a2c0cb4
@Korbik
Fix compilation errors
0573d34
@Korbik
Test: apply the google rules
c683d60
@Korbik
Review Feedback
98e468d
@Korbik Korbik force-pushed the java_checkstyle_google_format_migration branch from 3994d45 to 98e468d Compare March 18, 2025 05:39
@Korbik Korbik merged commit 8923fb1 into eclipse-biscuit:main Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubstan ghubstan ghubstan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Korbik @KannarFr @ghubstan