Remove ed-25519-java move to Bouncy Castle #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove ed-25519-java because of the security issue * Split the public keys representation to avoid the use of the SecurityProvide and heavy exception
Geal
reviewed
Apr 7, 2025
| @@ -157,7 +156,7 @@ private static SerializedBiscuit deserialize(Schema.Biscuit data) | |||
| external)); | |||
| } | |||
|
|
|||
| if (!(data.getProof().hasNextSecret() ^ data.getProof().hasFinalSignature())) { | |||
| if (data.getProof().hasNextSecret() == data.getProof().hasFinalSignature()) { | |||
There was a problem hiding this comment.
we should not allw the case where there's both a next secret and a final signature. The previous XOR was confusing but right.
Maybe split the two conditions? "empty proof" where both are false, and "invalid proof" where both are true
There was a problem hiding this comment.
Auto fix from the IDE. The result is the same than before but we have a case we shouldn’t have.
There was a problem hiding this comment.
Splitting the condition is the clearer solution.
Geal
requested changes
Apr 7, 2025
* Empty proof: no flag of the proof is set * Invalid proof: both flags of the proof are set (impossible case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/eclipse-biscuit/biscuit-java/security/dependabot/4