fix: don’t rely on lists in closures sample#289
Merged
Conversation
divarvel
force-pushed
the
fix-closures-sample
branch
2 times, most recently
from
395435f to
a82ad5f
Compare
The samples have been designed to map to specific features, in order to help gradual implementation of 3.3 features. The closures are meant to be implemented before lists and maps, so this sample should not rely on lists being implemented TODO: regen samples
divarvel
force-pushed
the
fix-closures-sample
branch
from
a82ad5f to
d2fb5ce
Compare
divarvel
added a commit
to eclipse-biscuit/biscuit
that referenced
this pull request
Sep 16, 2025
- Use sets in closures sample eclipse-biscuit/biscuit-rust#289 - Add a case for check all with no matches eclipse-biscuit/biscuit-rust#294 - Add missing case in heterogeneous equals sample eclipse-biscuit/biscuit-rust#309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples have been designed to map to specific features, in order to help gradual implementation of 3.3 features. The closures are meant to be implemented before lists and maps, so this sample should not rely on lists being implemented