Remove dead code in crypto and fix algo bug#322
Merged
divarvel merged 1 commit intoeclipse-biscuit:mainfrom Apr 22, 2026
Merged
Remove dead code in crypto and fix algo bug#322divarvel merged 1 commit intoeclipse-biscuit:mainfrom
divarvel merged 1 commit intoeclipse-biscuit:mainfrom
Conversation
The (ultimately not public) ed25519 and p256 crypto types expose a lot of methods that are never called; dead code left over from when the abstraction over multiple signing algorithms was added. The P256 code in several places had copy pasted code from ed25519 which incorrectly specified the algorithm as as ed25519; most of these were dead code, but one was in the Hash implementation of P256's public key, which incorrectly hashed the ed25519 identifier.
saoirse-a
commented
Apr 9, 2026
| impl Hash for PublicKey { | ||
| fn hash<H: std::hash::Hasher>(&self, state: &mut H) { | ||
| (crate::format::schema::public_key::Algorithm::Ed25519 as i32).hash(state); | ||
| (crate::format::schema::public_key::Algorithm::Secp256r1 as i32).hash(state); |
Contributor
Author
There was a problem hiding this comment.
highlighting this as the actual bug fix
divarvel
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (ultimately not public) ed25519 and p256 crypto types expose a lot of methods that are never called; dead code left over from when the abstraction over multiple signing algorithms was added.
The P256 code in several places had copy pasted code from ed25519 which incorrectly specified the algorithm as as ed25519; most of these were dead code, but one was in the Hash implementation of P256's public key, which incorrectly hashed the ed25519 identifier.