Skip to content

Resolve clippy and fmt issues#326

Merged
divarvel merged 2 commits intoeclipse-biscuit:mainfrom
saoirse-a:clippy-fixes
Apr 22, 2026
Merged

Resolve clippy and fmt issues#326
divarvel merged 2 commits intoeclipse-biscuit:mainfrom
saoirse-a:clippy-fixes

Conversation

@saoirse-a
Copy link
Copy Markdown
Contributor

This fixes issues identified by clippy - the most common was taking a reference to something that was already a reference.

A few warnings are supressed rather than fixed, mostly because fixing them could be a breaking change.

Also runs cargo fmt over the project.

This fixes issues identified by clippy - the most common was taking a
reference to something that was already a reference.

A few warnings are supressed rather than fixed, mostly because fixing
them could be a breaking change.

Also runs cargo fmt over the project.
@divarvel
Copy link
Copy Markdown
Contributor

This generally looks good to me. I know @Geal was not keen on having rustfmt early on, but it’s now common enough that it would be good now.

if we reformat the codebase we should also add a CI check as well imo.

@saoirse-a
Copy link
Copy Markdown
Contributor Author

The format changes were pretty much all in schema.rs; codebase seems to already have had rustfmt run over it at some point

@saoirse-a
Copy link
Copy Markdown
Contributor Author

That's actually also what's making the tests fail (its the test that diffs the schema with a generated schema), so if we want to do that we need to also update the test to format the code it generates

@divarvel
Copy link
Copy Markdown
Contributor

That's actually also what's making the tests fail (its the test that diffs the schema with a generated schema), so if we want to do that we need to also update the test to format the code it generates

i’d rather exclude generated files from rustfmt

@saoirse-a
Copy link
Copy Markdown
Contributor Author

Removed the format changes from the schema

@divarvel divarvel merged commit d8a8a01 into eclipse-biscuit:main Apr 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants