Resolve clippy and fmt issues#326
Conversation
This fixes issues identified by clippy - the most common was taking a reference to something that was already a reference. A few warnings are supressed rather than fixed, mostly because fixing them could be a breaking change. Also runs cargo fmt over the project.
|
This generally looks good to me. I know @Geal was not keen on having rustfmt early on, but it’s now common enough that it would be good now. if we reformat the codebase we should also add a CI check as well imo. |
|
The format changes were pretty much all in schema.rs; codebase seems to already have had rustfmt run over it at some point |
|
That's actually also what's making the tests fail (its the test that diffs the schema with a generated schema), so if we want to do that we need to also update the test to format the code it generates |
i’d rather exclude generated files from rustfmt |
|
Removed the format changes from the schema |
This fixes issues identified by clippy - the most common was taking a reference to something that was already a reference.
A few warnings are supressed rather than fixed, mostly because fixing them could be a breaking change.
Also runs cargo fmt over the project.