-
Notifications
You must be signed in to change notification settings - Fork 41
Fix(tests): start local agent by default #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b1ab93
to
979a98f
Compare
tests/tests/tier0/bluechi-agent-resolve-fqdn/test_bluechi_agent_resolve_fqdn.py
Show resolved
Hide resolved
...ests/tier0/bluechi-controller-socket-activation/test_bluechi_controller_socket_activation.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-monitor/test_bluechi_is_online_system_monitor.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system-monitor/test_bluechi_is_online_system_monitor.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/proxy-service-stop-bluechi-dep/test_proxy_service_stop_bluechi_dep.py
Outdated
Show resolved
Hide resolved
...xy-service-stop-requesting-with-unneeded/test_proxy_service_stop_requesting_with_unneeded.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/proxy-service-stop-requesting/test_proxy_service_stop_requesting.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/proxy-service-stop-target/test_proxy_service_stop_target.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, but otherwise LGTM
...hi-agent-connect-via-controller-address/test_bluechi_agent_connect_via_controller_address.py
Show resolved
Hide resolved
@dracher Any updates on this? |
Hi @engelmi , could you please take a look at the failing error? |
/packit test |
@dracher Have you run the tests locally? I am not sure what broke, the error with podmans connection pool for the UDS is quiet weird. Retriggered the packit tests, just to verify these still work. If yes, then its some infra issue on GH side. |
@engelmi yes i tested locally, and also all tests passed on testing-farm without errors |
Yes, logs in the newly triggered TF runs look good as well. Building the Edit: Aaaand quay is having issues so pushing new images fails at the moment. |
update all test cases(which requires 2 agents) to use node-local as second agent remove redundant agent configs and use the controller machine for local agent operations simplify test setups by removing unnecessary agent configuration current progress: - [x] monitor-wildcard-unit-changes - [x] proxy-service-start - [x] bluechi-reset-failed - [x] monitor-multiple-nodes-and-units - [x] monitor-system-status 3 agents - [x] bluechi-nodes-statuses - [x] bluechi-is-oneline-system - [x] bluechi-reset-failed - [x] bluechi-reset-failed-node - [x] proxy-service-stop-target - [x] proxy-service-stop-requesting - [x] proxy-service-stop-bluechi-dep - [x] bluechi-list-units-on-all-nodes - [x] monitor-wildcard-node-reconnect - [x] bluechi-is-online-system-monitor - [x] monitor-multiple-nodes-and-units - [x] proxy-service-fails-on-execstart - [x] proxy-service-fails-on-typo-in-file - [x] proxy-service-multiple-services-one-node - [x] service-fails-on-non-existent-service - [x] service-stop-requesting-with-unneeded - [x] multiple-services-multiple-nodes - [x] propagate-target-service-failure - [x] socket-activation-parallel - use global constant for node-ctrl name Fixes: eclipse-bluechi#1042
…a-controller-address
…DS connection by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging.
update all test cases(which requires 2 agents) to use node-local as second agent remove redundant agent configs and use the controller machine for local agent operations simplify test setups by removing unnecessary agent configuration
current progress:
bluechi-agent-invalid-port-configurationFixes: #1042