Skip to content

Fix(tests): start local agent by default #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

dracher
Copy link
Contributor

@dracher dracher commented Apr 2, 2025

update all test cases(which requires 2 agents) to use node-local as second agent remove redundant agent configs and use the controller machine for local agent operations simplify test setups by removing unnecessary agent configuration

current progress:

  • monitor-wildcard-unit-changes
  • proxy-service-start
  • bluechi-reset-failed
  • monitor-multiple-nodes-and-units
  • monitor-system-status 3 agents
  • bluechi-nodes-statuses
  • bluechi-is-oneline-system
  • bluechi-reset-failed
  • bluechi-reset-failed-node
  • proxy-service-stop-target
  • proxy-service-stop-requesting
  • proxy-service-stop-bluechi-dep
  • bluechi-list-units-on-all-nodes
  • monitor-wildcard-node-reconnect
  • bluechi-is-online-system-monitor
  • monitor-multiple-nodes-and-units
  • proxy-service-fails-on-execstart
  • proxy-service-fails-on-typo-in-file
  • bluechi-agent-invalid-port-configuration
  • proxy-service-multiple-services-one-node
  • service-fails-on-non-existent-service
  • service-stop-requesting-with-unneeded
  • multiple-services-multiple-nodes
  • propagate-target-service-failure
  • socket-activation-parallel

Fixes: #1042

@dracher dracher force-pushed the VROOM-26373 branch 2 times, most recently from 4b1ab93 to 979a98f Compare April 9, 2025 12:35
@coveralls
Copy link

coveralls commented Apr 9, 2025

Coverage Status

coverage: 82.331% (+0.07%) from 82.258%
when pulling 0e36bba on dracher:VROOM-26373
into 55d191a on eclipse-bluechi:main.

@dracher dracher marked this pull request as ready for review April 10, 2025 02:54
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but otherwise LGTM

@engelmi
Copy link
Member

engelmi commented May 5, 2025

@dracher Any updates on this?

@dracher
Copy link
Contributor Author

dracher commented May 13, 2025

Hi @engelmi , could you please take a look at the failing error?

@engelmi
Copy link
Member

engelmi commented May 13, 2025

/packit test

@engelmi
Copy link
Member

engelmi commented May 13, 2025

Hi @engelmi , could you please take a look at the failing error?

@dracher Have you run the tests locally? I am not sure what broke, the error with podmans connection pool for the UDS is quiet weird. Retriggered the packit tests, just to verify these still work. If yes, then its some infra issue on GH side.

@dracher
Copy link
Contributor Author

dracher commented May 13, 2025

@engelmi yes i tested locally, and also all tests passed on testing-farm without errors

@engelmi
Copy link
Member

engelmi commented May 13, 2025

@engelmi yes i tested locally, and also all tests passed on testing-farm without errors

Yes, logs in the newly triggered TF runs look good as well. Building the integration-test-base image and lets see then. I remember the integration tests on GH have passed previously as well, lets see.

Edit: Aaaand quay is having issues so pushing new images fails at the moment.

@engelmi engelmi mentioned this pull request May 14, 2025
dracher added 3 commits May 14, 2025 13:11
update all test cases(which requires 2 agents) to use node-local as second agent
remove redundant agent configs and use the controller machine for local agent operations
simplify test setups by removing unnecessary agent configuration

current progress:

- [x] monitor-wildcard-unit-changes
- [x] proxy-service-start
- [x] bluechi-reset-failed
- [x] monitor-multiple-nodes-and-units
- [x] monitor-system-status 3 agents
- [x] bluechi-nodes-statuses
- [x] bluechi-is-oneline-system
- [x] bluechi-reset-failed
- [x] bluechi-reset-failed-node
- [x] proxy-service-stop-target
- [x] proxy-service-stop-requesting
- [x] proxy-service-stop-bluechi-dep
- [x] bluechi-list-units-on-all-nodes
- [x] monitor-wildcard-node-reconnect
- [x] bluechi-is-online-system-monitor
- [x] monitor-multiple-nodes-and-units
- [x] proxy-service-fails-on-execstart
- [x] proxy-service-fails-on-typo-in-file
- [x] proxy-service-multiple-services-one-node
- [x] service-fails-on-non-existent-service
- [x] service-stop-requesting-with-unneeded
- [x] multiple-services-multiple-nodes
- [x] propagate-target-service-failure
- [x] socket-activation-parallel

- use global constant for node-ctrl name

Fixes: eclipse-bluechi#1042
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Merging.

@engelmi engelmi merged commit 0483408 into eclipse-bluechi:main May 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize number of nodes in integration tests by having bluechi-agent running on controller node
4 participants