Skip to content

Add UI Components for Trace Output Customization #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

williamsyang-work
Copy link
Contributor

@williamsyang-work williamsyang-work commented Apr 11, 2025

This PR enhances the React components package to support trace output customization, providing the UI elements needed to trigger and manage customized outputs. These changes complement the JSON configuration editor implemented in the main repository.

Key Features

  • Added ability to customize trace outputs directly from the Available Views panel
  • Implemented UI for adding custom analysis to existing outputs
  • Added support for removing custom outputs
  • Enhanced filter tree nodes to display interactive buttons

Implementation Details

  • Extended TreeNode interface to support enriched content rendering
  • Modified TableCell to use enriched content when available
  • Added button components for adding and removing outputs
  • Implemented handlers for customization and deletion operations
  • Added styling for custom buttons and UI elements

Visual Changes

  • Added "+" buttons next to customizable outputs
  • Added "x" buttons next to removable outputs
  • Improved layout with flex styling for better alignment

@williamsyang-work williamsyang-work changed the title Working stuff saved. Ammend this later Add UI Components for Trace Output Customization Apr 11, 2025
This commit enhances the react-components package to support the trace
output customization feature by adding UI elements that allow users to:

- Trigger customization of outputs directly from the Available Views panel
- Remove custom outputs they no longer need
- Visually identify customizable and removable outputs

The implementation extends the filter tree components to support
interactive elements and provides handlers for customization and
deletion operations. These UI enhancements complete the customization
workflow by connecting the JSON editor to the trace explorer interface.

Signed-off-by: Will Yang <[email protected]>
I had some weird linting errors and I don't have time to test if the changes
introduced bugs.

keeping this lint as a separate commit.  If there are bugs, you may need
to undo these changes

best,

will
@williamsyang-work
Copy link
Contributor Author

It looks like there are some failures in the table related unit tests.
I won't be able to address them until after next week.

@williamsyang-work williamsyang-work marked this pull request as ready for review April 11, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant