Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set application id for standalone debugger #804

Merged
merged 1 commit into from
May 29, 2024

Conversation

jonahgraham
Copy link
Member

Follow up for #782 to always explicitly set application

This wasn't needed in my development environment, but in the EPP version it was needed. I think it is because the normal config.ini specifies the application:

$ grep application eclipse/configuration/config.ini 
eclipse.application=org.eclipse.ui.ide.workbench

now that we don't define our own config.ini (see #782) we need to explicitly override the one set in the config.ini (if present)

@jonahgraham jonahgraham added this to the 11.6.0 milestone May 29, 2024
Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahgraham
Copy link
Member Author

The test fails don't have to do with this change - I will review them on main if they continue to fail after merging.

@jonahgraham jonahgraham merged commit 4eb08c8 into eclipse-cdt:main May 29, 2024
4 of 5 checks passed
@jonahgraham jonahgraham deleted the explicit-application branch May 29, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants