Skip to content

Add Git repository URL description #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vinokurig merged 1 commit into from
Apr 22, 2025
Merged

Add Git repository URL description #2895

vinokurig merged 1 commit into from
Apr 22, 2025

Conversation

@vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Apr 9, 2025

What does this pull request change?

Add Git repository URL description

What issues does this pull request fix or reference?

DO NOT MERGE until eclipse-che/che#23390 is fixed.

Specify the version of the product this pull request applies to

next

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from a team and deerskindoll as code owners April 9, 2025 07:34
@vinokurig vinokurig requested a review from amisevsk April 9, 2025 07:34
@github-actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

🎊 Navigate the preview: https://680b5b93fe888ef3cc98d36d--eclipse-che-docs-pr.netlify.app 🎊

deerskindoll
deerskindoll reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little tweak + a question

modules/end-user-guide/pages/starting-a-workspace-from-a-git-repository-url.adoc Outdated
Selecting a branch or a tag will add the reference parameter to the URL.
[NOTE]
====
As an experimental feature, we support a repository url of a directory with a devfile or a repository url of the devfile.
Copy link
Contributor

@deerskindoll deerskindoll Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is an experimental feature the same as a tech preview?

Copy link
Contributor Author

@vinokurig vinokurig Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that it is the same. From my understanding, the idea of an experimental feature is that it will not necessary be a part of the product in future in case we have some problems with it.

Copy link
Contributor

@deerskindoll deerskindoll Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does the info come from?

Copy link
Contributor Author

@vinokurig vinokurig Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ibuziuk

Copy link
Member

@ibuziuk ibuziuk Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be considered as a regular GitHub related feature for Dev Spaces 3.21, not experimental
Please, reword

Copy link
Contributor Author

@vinokurig vinokurig Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the experimental feature mention @ibuziuk @deerskindoll please take a look.

deerskindoll
deerskindoll approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a slight tweak

@vinokurig
Copy link
Contributor Author

vinokurig commented Apr 21, 2025 •
edited
Loading

@deerskindoll Thank you for the review, but I can not merge the pull request due to the failing build job. Looks like this error came from an earlier commit. Could you please take a look?

@vinokurig vinokurig merged commit a6314ff into main Apr 22, 2025
10 checks passed
@vinokurig vinokurig deleted the che-23390 branch April 22, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk amisevsk is a code owner automatically assigned from eclipse-che/ecd-che-docs-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinokurig @ibuziuk @deerskindoll