chore: Add labels to prevent mounting CM into user containers #2896
Conversation
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://67fd2762d7188eca79fe2b99--eclipse-che-docs-pr.netlify.app 🎊 |
| labels: | ||
| controller.devfile.io/watch-configmap: "false" | ||
| controller.devfile.io/mount-to-devworkspace: "false" | ||
| data: |
There was a problem hiding this comment.
are these labels actual when the ConfigMap is created in the user's namespace?
or
they are for the eclipse-che namespace only?
There was a problem hiding this comment.
Only when CM is created in eclipse-che namespace
There was a problem hiding this comment.
The current doc is for the user's namespace ConfigMap:
We only have a tip, that the same ConfigMap can be used for the eclipse-che namespace:
So, maybe it makes sense to add some additional info about those labels and a difference for user's namespace vs eclipse-che namespace
There was a problem hiding this comment.
btw
for the eclipse-che namespace we have example of CM here https://eclipse.dev/che/docs/stable/administration-guide/configuring-a-user-namespace/
so - should these 2 labels be part of that example?
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
tolusha
force-pushed
the
updateeditorconfigurationarticle
branch
from
98945ed to
b0e5159
Compare
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
* chore: Add labels to prevent mounting CM into user containers Signed-off-by: Anatolii Bazko <[email protected]>
…#2898) * chore: Add labels to prevent mounting CM into user containers Signed-off-by: Anatolii Bazko <[email protected]>
What does this pull request change?
Add labels to prevent mounting CM into user containers
What issues does this pull request fix or reference?
https://issues.redhat.com/browse/CRW-8313
Specify the version of the product this pull request applies to
main
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.