Skip to content

feat: add info about hiding editor definitions #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deerskindoll merged 6 commits into from
May 28, 2025
Merged

feat: add info about hiding editor definitions #2908

deerskindoll merged 6 commits into from
May 28, 2025

Conversation

@olexii4
Copy link
Contributor

@olexii4 olexii4 commented May 23, 2025 •
edited
Loading

What does this pull request change?

Add info about hiding editor definitions:

  • Show deprecated editors definitions
    Знімок екрана 2025-05-23 о 10 04 27
  • Concealing editors definitions by editor ID
    Знімок екрана 2025-05-26 о 20 04 47

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Che 7.102 - DS 3.21

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@olexii4 olexii4 requested review from a team and deerskindoll as code owners May 23, 2025 07:18
@olexii4 olexii4 requested a review from tolusha May 23, 2025 07:18
@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

🎊 Navigate the preview: https://6837025434d5dba9b3c6372b--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

Click here to review and test in web IDE: Contribute

@tolusha
Copy link
Contributor

tolusha commented May 26, 2025

Please remove this article [1].
I believe it is better to use word conceal instead of hide.
Add steps how to figure out editors ids

[1] https://eclipse.dev/che/docs/stable/administration-guide/concealing-editors-definitions/

@deerskindoll
Copy link
Contributor

deerskindoll commented May 26, 2025

Please remove this article [1]. I believe it is better to use word conceal instead of hide. Add steps how to figure out editors ids

[1] https://eclipse.dev/che/docs/stable/administration-guide/concealing-editors-definitions/

agreed

dmytro-ndp
dmytro-ndp approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

che-cluster configuration in hiding-editors-definitions.adoc and show-deprecated-editors-definitions.adoc had been tested successfully with DS 3.21.0.RCs

@olexii4
Copy link
Contributor Author

olexii4 commented May 26, 2025

@tolusha @deerskindoll I have fixed.

@svor
Copy link
Contributor

svor commented May 27, 2025

Do we really need the word definitions here? To me, it feels redundant, Show deprecated editors or Concealing editors should be enough.
The term “editor definition” typically refers to the declaration or configuration of an editor, but in this case, the dashboard simply controls the visibility of editors in general.

@olexii4 @tolusha @deerskindoll WDYT?

@olexii4
Copy link
Contributor Author

olexii4 commented May 27, 2025 •
edited
Loading

Do we really need the word definitions here? To me, it feels redundant, Show deprecated editors or Concealing editors should be enough. The term “editor definition” typically refers to the declaration or configuration of an editor, but in this case, the dashboard simply controls the visibility of editors in general.

@olexii4 @tolusha @deerskindoll WDYT?

@svor I have fixed it.

tolusha
tolusha approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deerskindoll
Pls review

deerskindoll
deerskindoll reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments

deerskindoll
deerskindoll approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll deerskindoll merged commit 7b1fee9 into main May 28, 2025
11 checks passed
@deerskindoll deerskindoll deleted the hiding_editors branch May 28, 2025 21:28
deerskindoll pushed a commit that referenced this pull request May 28, 2025
@olexii4 @deerskindoll
feat: add info about hiding editor definitions (#2908)
d875875 
* feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

* fixup! feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

* fixup! fixup! feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

* fixup! fixup! fixup! feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

* fixup! fixup! fixup! fixup! feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

* fixup! fixup! fixup! fixup! fixup! feat: hiding editors definitions

Signed-off-by: Oleksii Orel <[email protected]>

---------

Signed-off-by: Oleksii Orel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@tolusha tolusha tolusha approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

Assignees

No one assigned

Labels

backported to 7.102.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@olexii4 @tolusha @deerskindoll @svor @dmytro-ndp