Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Bitbucket Server getUser request (#790) #792

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

vinokurig
Copy link
Contributor

Since Bitbucket Server version 8.19.14, the /plugins/servlet/applinks/whoami request does not return username, if PAT is used. Change the getUser() request to /rest/api/1.0/application-properties instead and extract the username from the response headers.

What does this PR do?

backport from #790

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Since Bitbucket Server version 8.19.14, the /plugins/servlet/applinks/whoami request does not return username, if PAT is used. Change the getUser() request to /rest/api/1.0/application-properties instead and extract the username from the response headers.
@openshift-ci openshift-ci bot removed the lgtm label Apr 2, 2025
Copy link

openshift-ci bot commented Apr 2, 2025

New changes are detected. LGTM label has been removed.

@vinokurig vinokurig merged commit e871942 into 7.100.x Apr 2, 2025
5 checks passed
@vinokurig vinokurig deleted the CRW-8246_7.100.x branch April 2, 2025 12:46
@devspacesbuild
Copy link

Build 3.20 :: server_3.20/2: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: server_3.20/2: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.20/81 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: copyIIBsToQuay/2946: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.20 :: get-sources-rhpkg-container-build_3.20/127: SUCCESS

devspaces-operator-bundle : 3.20 :: Build 67198514 : quay.io/devspaces/devspaces-operator-bundle:3.20-9
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.20/27 triggered;
Bundle CSV related images:

@devspacesbuild
Copy link

Build 3.20 :: sync-to-downstream_3.20/82: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.20/127 triggered; /job/DS_CI/job/dsc_3.20 triggered;

@devspacesbuild
Copy link

Build 3.20 :: operator-bundle_3.20/57: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.20/82 triggered

@devspacesbuild
Copy link

Build 3.20 :: dsc_3.20/9: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.20 :: update-digests_3.20/105: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.20/57 triggered

@devspacesbuild
Copy link

Build 3.20 :: dsc_3.20/9: SUCCESS

3.20.0-CI

@devspacesbuild
Copy link

Build 3.20 :: server_3.20/3: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: server_3.20/3: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.20/89 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: copyIIBsToQuay/2948: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.20 :: sync-to-downstream_3.20/90: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.20/140 triggered; /job/DS_CI/job/dsc_3.20 triggered;

@devspacesbuild
Copy link

Build 3.20 :: operator-bundle_3.20/59: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.20/90 triggered

@devspacesbuild
Copy link

Build 3.20 :: dsc_3.20/11: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.20 :: update-digests_3.20/112: SUCCESS

Detected new images: rebuild operator-bundle
* code
* dashboard
* idea
* jetbrains-ide
* server; /DS_CI/operator-bundle_3.20/59 triggered

@devspacesbuild
Copy link

Build 3.20 :: dsc_3.20/11: SUCCESS

3.20.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants