-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the Bitbucket Server getUser request (#790) #792
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since Bitbucket Server version 8.19.14, the /plugins/servlet/applinks/whoami request does not return username, if PAT is used. Change the getUser() request to /rest/api/1.0/application-properties instead and extract the username from the response headers.
d2e5dbc
to
b727e6e
Compare
New changes are detected. LGTM label has been removed. |
Build 3.20 :: server_3.20/2: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.20/81: Console, Changes, Git Data |
Build 3.20 :: push-latest-container-to-quay_3.20/26: Console, Changes, Git Data |
Build 3.20 :: get-sources-rhpkg-container-build_3.20/126: server : 3.20 :: Build 67198111 : quay.io/devspaces/server-rhel9:3.20-12 |
Build 3.20 :: update-digests_3.20/105: Console, Changes, Git Data |
Build 3.20 :: server_3.20/2: Upstream sync done; /DS_CI/sync-to-downstream_3.20/81 triggered |
Build 3.20 :: operator-bundle_3.20/57: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.20/82: Console, Changes, Git Data |
Build 3.20 :: push-latest-container-to-quay_3.20/27: Console, Changes, Git Data |
Build 3.20 :: copyIIBsToQuay/2946: Console, Changes, Git Data |
Build 3.20 :: get-sources-rhpkg-container-build_3.20/127: devspaces-operator-bundle : 3.20 :: Build 67198514 : quay.io/devspaces/devspaces-operator-bundle:3.20-9 |
Build 3.20 :: sync-to-downstream_3.20/82: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.20/127 triggered; /job/DS_CI/job/dsc_3.20 triggered; |
Build 3.20 :: operator-bundle_3.20/57: Upstream sync done; /DS_CI/sync-to-downstream_3.20/82 triggered |
Build 3.20 :: dsc_3.20/9: Console, Changes, Git Data |
Build 3.20 :: update-digests_3.20/105: Detected new images: rebuild operator-bundle |
Build 3.20 :: dsc_3.20/9: 3.20.0-CI |
Build 3.20 :: server_3.20/3: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.20/89: Console, Changes, Git Data |
Build 3.20 :: push-latest-container-to-quay_3.20/29: Console, Changes, Git Data |
Build 3.20 :: get-sources-rhpkg-container-build_3.20/138: server : 3.20 :: Build 67226932 : quay.io/devspaces/server-rhel9:3.20-13 |
Build 3.20 :: server_3.20/3: Upstream sync done; /DS_CI/sync-to-downstream_3.20/89 triggered |
Build 3.20 :: update-digests_3.20/112: Console, Changes, Git Data |
Build 3.20 :: operator-bundle_3.20/59: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.20/90: Console, Changes, Git Data |
Build 3.20 :: push-latest-container-to-quay_3.20/33: Console, Changes, Git Data |
Build 3.20 :: copyIIBsToQuay/2948: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.20/90: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.20/140 triggered; /job/DS_CI/job/dsc_3.20 triggered; |
Build 3.20 :: operator-bundle_3.20/59: Upstream sync done; /DS_CI/sync-to-downstream_3.20/90 triggered |
Build 3.20 :: dsc_3.20/11: Console, Changes, Git Data |
Build 3.20 :: update-digests_3.20/112: Detected new images: rebuild operator-bundle |
Build 3.20 :: dsc_3.20/11: 3.20.0-CI |
Since Bitbucket Server version 8.19.14, the /plugins/servlet/applinks/whoami request does not return username, if PAT is used. Change the getUser() request to /rest/api/1.0/application-properties instead and extract the username from the response headers.
What does this PR do?
backport from #790
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.