This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Pin temporarily to upstream Theia commit#1059
Merged
RomanNikitenko merged 1 commit intoeclipse-che:masterfrom Mar 29, 2021
Merged
Pin temporarily to upstream Theia commit#1059RomanNikitenko merged 1 commit intoeclipse-che:masterfrom
RomanNikitenko merged 1 commit intoeclipse-che:masterfrom
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
azatsarynnyy
approved these changes
Mar 29, 2021
Member
Author
|
Using these changes within testing (what commit caused the bug) I have got the successful tests here, but let's wait for the required checks in the current PR... |
Contributor
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
benoitf
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
What does this PR do?
Some breaking changes came from the upstream, please see more details eclipse-che/che#19441
So we are pinning temporarily Theia commit to have the functionality working
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19441
How to test this PR?
The tests should be happy.
The
Workspacepanel actions should work.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable