Check path to be a file when reading certificates

[vinokurig]

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Fixes a bug when the plugins view shows an empty list.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1710

How to test this PR?

1. Start a workspace from devfile:

apiVersion: 1.0.0
metadata:
  name: wksp-custom-tki1v
components:
  - type: cheEditor
    reference: '<link to the generated meta.yaml, will be available when the PR is opened>'

2. Open the Plugins view: View => Plugins
3. See: plugins list must be loaded.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

[codecov]

Codecov Report

Merging #1072 (bd7afd8) into master (eeb4526) will increase coverage by 1.83%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage   29.45%   31.29%   +1.83%     
==========================================
  Files         277      277              
  Lines        9336     9356      +20     
  Branches     1380     1391      +11     
==========================================
+ Hits         2750     2928     +178     
+ Misses       6487     6331     -156     
+ Partials       99       97       -2     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts	0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts	0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts	0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts	0.00% <0.00%> (ø)
...ces/src/node/che-theia-preferences-synchronizer.ts	0.00% <0.00%> (ø)
...e-theia-workspace/src/node/che-workspace-server.ts	0.00% <0.00%> (ø)
generator/src/init-sources.ts	98.17% <ø> (ø)
...ainers-plugin/src/containers-tree-data-provider.ts	0.00% <0.00%> (ø)
plugins/task-plugin/src/task/che-task-runner.ts	0.00% <ø> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9460c2c...bd7afd8. Read the comment docs.

[azatsarynnyy]

@vinokurig are you sure the failed HappyPath tests are not related to the PR changes?
On the previous PR it passed.

[vinokurig]

I'll try to rerun tests

[vinokurig]

[crw-ci-test]

[vinokurig]

Looks like it doesn't work when the PR is closed :)

[RomanNikitenko]

@vinokurig
FYI

At the same time PR check doesn't work normally at the moment, because CRW Jenkins CI continues suffering from infrastrucure outage introduced a few days ago https://one.redhat.com/legacy/outages/list/details/606a7ab556897a049f735d2f .

[RomanNikitenko]

I have restarted the jobs with happy path tests for the current PR, waiting...

[vinokurig]

Thanks @RomanNikitenko

[RomanNikitenko]

The tests have failed o the same step:

There are 2 jobs for ubi8 are still in progress, let's wait the results.

[RomanNikitenko]

Unfortunately all jobs have failed and the cause of the problem is the same, please see the screenshot above.

[vinokurig]

I don't think that my changes caused workspace start error, I've checked it locally several times. I propose to wait for the nightly tests against master.

[RomanNikitenko]

I have started the checks for all jobs in the test PR without your changes #1049

[vinokurig]

I've tried the latest che-theia image which contains my changes and it works ok:

[RomanNikitenko]

Maybe something wrong with Happy Path tests...
So we need help from QE team.

[vinokurig]

Let's wait for results of your draft PR, then I'll rise this question in the QE channel

[dmytro-ndp]

@vinokurig : about happy path tests failure #1072 (comment)
Happy path tests from master branch are not compatible with Eclipse Che stable version, that is 7.28.0

[vinokurig]

So this is expected?

[dmytro-ndp]

Yes, it is.

[vinokurig]

OK, thanks.