Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

chore: faster build of docker images #1279

Open
vitaliy-guliy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: faster build of docker images #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ set -e
set -o pipefail

parse "$@"
yarn ${YARN_OPTS}
Copy link
Copy Markdown
Member

@azatsarynnyy azatsarynnyy Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building it with yarn allows failing faster when there's a compilation error. So, not to wait while it fails within a docker build.

Copy link
Copy Markdown
Member

@azatsarynnyy azatsarynnyy Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, as we have a dedicated GH action for validating sources build, it's a good idea to get rid of it.

Copy link
Copy Markdown
Member

@azatsarynnyy azatsarynnyy Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take care of the --root-yarn-opts parameter as well. Otherwise, we'll have the dead code.
See the details in the PR https://github.com/eclipse-che/che-theia/pull/725/files
Also, need to check ./build.sh --root-yarn-opts:--ignore-scripts calls.


#Added to handle experimental Travis tag
if [[ -n "${TAG:-}" ]]; then
Expand Down