Skip to content

Use full version in shared objects #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eboasson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use full version in shared objects #1696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ target_include_directories(
$<BUILD_INTERFACE:$<TARGET_PROPERTY:ddsrt,INTERFACE_INCLUDE_DIRECTORIES>>)

# SOVERSION should increase on incompatible ABI change
set_target_properties(ddsc PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${PROJECT_VERSION_MAJOR})
set_target_properties(ddsc PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${PROJECT_VERSION})

# define target property to indicate if Cyclone DDS is compiled with SHM support
define_property(TARGET
Expand Down
2 changes: 2 additions & 0 deletions src/core/cdr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ else()

add_library(${PROJECT_NAME}::cdr ALIAS cdr)

set_target_properties(cdr PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${PROJECT_VERSION})

target_sources(cdr PRIVATE ${srcs_cdr} ${hdrs_private_cdr})
target_include_directories(cdr PUBLIC "${CMAKE_CURRENT_LIST_DIR}/include"
"${PROJECT_BINARY_DIR}/include"
Expand Down
2 changes: 1 addition & 1 deletion src/idl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ set_target_properties(
idl PROPERTIES
OUTPUT_NAME "cycloneddsidl"
VERSION ${PROJECT_VERSION}
SOVERSION ${PROJECT_VERSION_MAJOR})
SOVERSION ${PROJECT_VERSION})

generate_export_header(idl EXPORT_FILE_NAME include/idl/export.h)

Expand Down