#2319 support placeholder replacement in the migrateDefinition #2321
+764
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
System tests run: https://github.com/eclipse-ditto/ditto/actions/runs/21469939032 |
thjaeckle
reviewed
Jan 29, 2026
| return "{{ " + THING_JSON_PREFIX_COLON + pointer + " }}"; | ||
| } | ||
|
|
||
| private static final class ThingJsonPlaceholder implements Placeholder<JsonObject> { |
Member
There was a problem hiding this comment.
@hu-ahmed this is basically a copy of ImmutableThingJsonPlaceholder from ditto-edge-service, right?
We should probably move ImmutableThingJsonPlaceholder to the ditto-placeholders module, make it work directly on JsonObject (to not have a dependency to the thing model) and re-use it also here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2319