fix: use numeric JWT claims instead of ISO-8601 #4992
+63
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
bug
paullatzelsperger
force-pushed
the
fix/use_temporal_values
branch
from
56dce0d to
7823365
Compare
paullatzelsperger
force-pushed
the
fix/use_temporal_values
branch
from
06cb8fd to
4c3be39
Compare
paullatzelsperger
force-pushed
the
fix/use_temporal_values
branch
from
4c3be39 to
62f6ff6
Compare
ndr-brt
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR changes the use of ISO-8601 strings as temporal JWT claims to be numeric date values.
Why it does that
RFC 7519 requires them to be
NumericDatevalues, i.e. Epoch secondsFurther notes
The culprit is the Nimbus library, which fails to parse JSON Web tokens where the
nbf,expandiatclaims are not numeric.Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4991
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.