Fixed NPE when check 'behind-proxy' is enabled or not on an ssh node. - #26167
Open
JackienStephan wants to merge 2 commits into
Open
Fixed NPE when check 'behind-proxy' is enabled or not on an ssh node.#26167JackienStephan wants to merge 2 commits into
JackienStephan wants to merge 2 commits into
Conversation
When isBehindProxyEnabled() method is executed on a remote node instance, for example, execute the start-instance command on das, and the target is an instance on an ssh node, a <server> element named "server" cannot be found in the instance's domain.xml. would result in NPE when call "getConfig()" method. it would be better to find the <server> element of the current instance.
dmatej
approved these changes
Aug 7, 2026
OndroMih
reviewed
Aug 27, 2026
OndroMih
requested changes
Aug 27, 2026
OndroMih
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
isBehindProxyEnabled()method is executed on a remote node instance,for example, execute the
start-instancecommand on das, and the target is an instance on an ssh node,a server element named "server" cannot be found in the instance's
domain.xml.So
domain.getServerNamed("server")here returns null, resulting in NPE when callgetConfig().It would be better to find the server element of the current instance.
With this issue,
start-instancecommand targeting on ssh instances would succeed, butlist-instancecannot get the correct running status of target instances. It would always be "stopped".Then
stop-instancecommand on the target instances always timeout.The only temporary workaround I found for now, is to ssh to the remote instance server and execute
stop-local-instance.