Skip to content

Fix metadata parser in RemoteAdminCommand.java #26168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackienStephan wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −3
Open

Fix metadata parser in RemoteAdminCommand.java #26168

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2349c9a
Fixed wrong operation when parseMetadata.
JackienStephan Aug 6, 2026
8af41e3
Fixed wrong operation when parseMetadata. Missing "break" statement.
JackienStephan Aug 6, 2026
e670312
Remove commented-out code in RemoteAdminCommand.java
dmatej Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions nucleus/admin/util/src/main/java/com/sun/enterprise/admin/remote/RemoteAdminCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
import org.glassfish.common.util.admin.AuthTokenManager;
import org.glassfish.main.jdke.i18n.LocalStringsImpl;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
import org.w3c.dom.NamedNodeMap;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
Expand Down Expand Up @@ -1172,9 +1173,18 @@ private CommandModel parseMetadata(InputStream in, Charset charset, StringBuilde
if (ok(cause)) {
errors.append(cause);
} else {
Node mp = report.getFirstChild(); // message-part
if (mp != null) {
cause = getAttr(mp.getAttributes(), "message");
// Because of the OutputKeys.INDENT has been set to "yes" in the XMLContentActionReporter,
// message-part cannot be fetched by simply call "getFirstChild()" method,
// that would be a text node with blank content as node value now.
// and its attributes would be null, then result in the NPE in "getAttr" method.
// so we need to find the first message-part element.
NodeList children = report.getChildNodes();
for (int i = 0; i < children.getLength(); i++) {
Node mp = children.item(i);
if (mp instanceof Element el && "message-part".equals(el.getTagName())) {
cause = getAttr(mp.getAttributes(), "message");
break;
}
}
if (ok(cause)) {
errors.append(cause);
Expand Down
Loading