Fix ClassFormatError when reading type parameter annotations on JDK 25

[jchalou]

No description provided.

[jtulach]

• I like the fix
• I have already accepted it into (now archived) https://github.com/jtulach/netbeans-apitest
• it seems good enough to go into this repository as well

[scottmarlow]

@jchalou have you signed the Eclipse Contributor Agreement yet? One of your email addresses added to https://github.com/jchalou needs to be the same email as you used to sign the Eclipse Contributor Agreement.

@jtulach your commits are already in the https://github.com/eclipse-ee4j/jakartaee-tck-tools fork of sigtest (perhaps @jchalou also) but would be good to have both of you to sign the Eclipse Contributor Agreement and contribute here.

[jchalou]

@scottmarlow I updated my employer in my eclipse account and the employer is an eclipse member organization, so now there is a checkmark next to the "Eclipse Contributor Agreement" in my account. Is that sufficient?

[scottmarlow]

@scottmarlow I updated my employer in my eclipse account and the employer is an eclipse member organization, so now there is a checkmark next to the "Eclipse Contributor Agreement" in my account. Is that sufficient?

I still see an error:

Your eclipse account is associated with an email address that must match an email associated with your https://github.com/jchalou settings. You can have more than one email address associated with your https://github.com/jchalou settings but at least one of those email addresses must match the email associated with your Eclipse account.

[jchalou]

@scottmarlow My email address matches but I have it set to private in github settings. I guess it has to be public. Is that it? UPDATE: I think in this case I have to create new eclipse account with my organization's email address.

[jchalou]

@scottmarlow It should be ok now.

[jchalou]

@scottmarlow How does the PR get merged now that it is approved? Thanks!

[scottmarlow]

@scottmarlow How does the PR get merged now that it is approved? Thanks!

I can merge it now but only waited to see if others have feedback. Will merge...

[scottmarlow]

Thanks @jchalou + @jtulach! I am very happy to see both of you here contributing!

[jchalou]

Thanks @scottmarlow!

[jchalou]

@scottmarlow When will sigtest-2.7 with the fix be released? The last release (2.6) is Feb 14, 2025, do you plan to release next version soon? Thanks!

[scottmarlow]

@scottmarlow When will sigtest-2.7 with the fix be released? The last release (2.6) is Feb 14, 2025, do you plan to release next version soon? Thanks!

Yes will do that soon.

[scottmarlow]

Looks like we need to update the project pom.xml dependency to refer to a specific version of org.netbeans.tools:ct-sym instead of latest:

     <dependency>
            <groupId>org.netbeans.tools</groupId>
            <artifactId>ct-sym</artifactId>
            <version>latest</version>
            <scope>system</scope>
            <systemPath>${ct.sym}</systemPath>
            <type>jar</type>
        </dependency>

We are getting build error https://ci.eclipse.org/jakartaee-platform/job/JakartaEE-TCK/job/SigtestPluginRelease/10/console:

Deployment 639c87db-2c7c-41f9-b77a-51d4c760903e failed
pkg:maven/jakarta.tck/sigtest-maven-plugin@2.7:

• Dependency version cannot contain 'latest' in version for dependency: org.netbeans.tools:ct-sym
• 'Scope: system' is not allowed in dependency: org.netbeans.tools:ct-sym