-
Notifications
You must be signed in to change notification settings - Fork 375
Issue 6036: Support for Jackson3 #6048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Jens-Otto Larsen <[email protected]>
|
Great work, thank you so much for your big contribution! ❤️ Please be aware: |
|
@reneleonhardt I'm looking into the copyright-warnings. I am not familiar with the practices here, so I'll need some guidance |
Signed-off-by: Jens-Otto Larsen <[email protected]>
Signed-off-by: Jens-Otto Larsen <[email protected]>
|
I'm not a Jersey maintainer, I guess glassfish-copyright-maven-plugin wants a copyright + license notice in every file, it will probably be enough to copy from another source file and change the year to 2026 for new files. |
|
Jenkins stopped working after 1h23 mins - in the middle of jersey-tests-osgi-functional (287/387). Can someone with access trigger a new build? Or should I just commit a NOOP-change ? |
Signed-off-by: Jens-Otto Larsen <[email protected]>
Signed-off-by: Jens-Otto Larsen <[email protected]>
|
Megabytes of logs... I remember when unit tests were only allowed to print dots, good times 😄 |
|
@jolarsen Thank you for adding the Jackson3 support! In order to avoid dependency convergence, I've also adopted Jackson 2.20 (my commit is added to your PR). In total, this should work, and all checks should be OK now. |
Signed-off-by: Maxim Nesen <[email protected]>
|
Oops, I had to re-write that because I didn't notice that the 2.20 is only applicable for Jackson annotations. |
Signed-off-by: Jens-Otto Larsen <[email protected]>
|
@senivam Jackson3 uses com.fasterxml for jackson-annotations - and needs 2.20 for JsonFormat.POJO But lets try to find a path to complete the PR. There are many users who want to do the Jackson3-migration - which is a fair amount of changes - new coordinates, immutable mappers, builders, etc. |
|
@jolarsen , I was hoping to solve this without exclusions. Dependency convergence check should work similarly both locally and on Jenkins. It, however, requires previously built artifacts to be prepared for the check. As I'm running it with Jackson 2.20.1 adopted, it does not fail for jackson annotations convergence. |
|
When I tried locally - mvn enforcer reported problems with tests/integration/jackson-14 - but not media/json-jackson. |
|
@jolarsen OK, clear. I hope this time the build will finally pass OK. |
|
Jjenkins resigned with "pool-979-thread-1: Retried waiting for GCLocker too often allocating 1250002 words" |
|
Finally it passed fine |
|
@senivam Thanks for helping out ! |
New module json-jackson3 in media, examples, and performance tests. Based on the existing json-jackson module
For discussion:
Testing: Apart from updated tests in media / json-jackson3, I have done this: