Skip to content

Fixes #171: Inconsistent owner document#173

Open
lukasj wants to merge 2 commits into
eclipse-ee4j:masterfrom
lukasj:is171
Open

Fixes #171: Inconsistent owner document#173
lukasj wants to merge 2 commits into
eclipse-ee4j:masterfrom
lukasj:is171

Conversation

@lukasj

@lukasj lukasj commented Feb 26, 2021

Copy link
Copy Markdown
Member

there were 2 problems:

  • element attributes were not fully wrapped
  • element.insertBefore returns different instance of the node passed in, so it did not have our user data set

Fixes #171

@lukasj lukasj changed the title #171: Inconsistent owner document Fixes #171: Inconsistent owner document Feb 26, 2021
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@sephiroth-j

sephiroth-j commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

I think this could fix #183 as well.

edit: no, it does not but found the solution while testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent owner document

3 participants