[663] Yasson 3.0.3 - Serialization of a Map fails if the key is of a type implemented as SupportedMapKey and using a csutom Serializer#664
Merged
Verdent merged 2 commits intoeclipse-ee4j:masterfrom Jul 11, 2025
Conversation
Contributor
Author
Member
Contributor
Author
|
@Verdent please provide a link tot eh ECA to sign... |
Contributor
Author
Contributor
Author
jamezp
requested changes
Apr 9, 2025
src/main/java/org/eclipse/yasson/internal/serializer/MapSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/yasson/internal/serializer/MapSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/yasson/internal/serializer/MapSerializer.java
Outdated
Show resolved
Hide resolved
| * @return whether a custom JsonSerializer for the type is available | ||
| */ | ||
| public static boolean hasCustomJsonbSerializer(Class<?> clazz, JsonbContext jsonbContext) { | ||
| return jsonbContext.getComponentMatcher().getSerializerBinding(clazz, null).isPresent(); |
Member
There was a problem hiding this comment.
Should we be passing the propertyCustomization parameter from SerializationModelCreator.createMapSerializer() as the null parameter here?
Contributor
Author
There was a problem hiding this comment.
Hm, not sure here... This method is only to determine if there's a custom Serializer at all...
Using the custom JsonbSerializer even when serializing an already supported Map key
jbaesner
force-pushed
the
issue663
branch
2 times, most recently
from
75264e2 to
873bfe4
Compare
rebased on current 'master' incorporated review comments
jamezp
approved these changes
Apr 14, 2025
Member
|
This looks good to me. What do you think @Verdent? |
Contributor
Author
|
@Verdent I see the workflow needs an approval from a maintainer. Is there something missing here? What need to be done to get this PR merged? |
Contributor
Author
Verdent
approved these changes
Jul 11, 2025
Member
|
Thank you for your contribution! And sorry for it to take so long to get in :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #663