fix: serve the website from the enclave.eclipse.dev root - #55
Merged
Conversation
The site moved from a planned eclipse.dev/enclave subpath to its own subdomain, so production builds no longer need a path prefix. Deployed docs pages referenced /enclave/docs/assets/..., which 404s at the root domain. Also re-create the CNAME file on every deploy: actions-gh-pages replaces the published tree, which would delete the file the Pages settings UI created and unset the custom domain.
|
Updated project name from 'Enclave' to 'Eclipse Enclave' and revised links.
planger
marked this pull request as ready for review
August 24, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The website is now hosted at https://enclave.eclipse.dev, so it is served from a
domain root rather than the planned
eclipse.dev/enclavesubpath. Productionbuilds still injected a
/enclave/docs/base path, which broke the deployeddocs: pages referenced
/enclave/docs/assets/...(404 today) while the filesthemselves sit at
/docs/assets/..., so no CSS or JS loaded.DOCS_BASE_URLand theworkflow_dispatchdefault drop the/enclaveprefix, so the docs build with the default/docs/.docusaurus.config.jssetsurl: https://enclave.eclipse.devfor correctsitemap and canonical URLs.
CNAMEfile on every deploy. This isa latent trap unrelated to the base path:
actions-gh-pagesreplaces thepublished tree, so the next deploy would have deleted the file the Pages
settings UI created and unset the custom domain. Otterdog cannot manage this,
as its repository resource has no custom-domain property.
index.htmlgainsog:url, a canonical link, and an absoluteog:image. Therelative
og:imagenever worked for social crawlers; a stable domain is whatwas missing. These are the only place the production domain is hardcoded.
package-lock.jsonpicks up a two-line rename: the lockfilenamewas stillwebsite-docswhilepackage.jsonsayseclipse-enclave-docs.The preview workflow keeps its
/enclave-website-previews/pr-previews/pr-N/docs/base path, which is still correct for that host.
How to test
Built pages should reference
/docs/assets/..., andsitemap.xmlshould usehttps://enclave.eclipse.dev/docs/.... I verified 200s on/,/docs/, allthree doc pages, the docs CSS bundle, and the marketing assets.
website/preview.shcovers the same ground. The only build warnings are the four intentional
../links from docs back to the marketing home, which is why
onBrokenLinksiswarn.To confirm the current breakage before the fix lands:
Follow-ups
.eclipsefdnsetshomepage: https://www.eclipse.dev/enclavefor all three repos. That URL is now wrong and needs a separate PR there. -> fix: website URL .eclipsefdn#4
Breaking changes
Review checklist