Skip to content

Clean Code for bundles/org.eclipse.equinox.p2.ui.admin#931

Open
eclipse-equinox-bot wants to merge 2 commits intomasterfrom
clean-code/bundles/org.eclipse.equinox.p2.ui.admin
Open

Clean Code for bundles/org.eclipse.equinox.p2.ui.admin#931
eclipse-equinox-bot wants to merge 2 commits intomasterfrom
clean-code/bundles/org.eclipse.equinox.p2.ui.admin

Conversation

@eclipse-equinox-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-equinox-bot
Copy link
Contributor Author

eclipse-equinox-bot commented Aug 4, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.p2.ui.admin/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 79290db532b3129caf63a6971bedd82a1d7eb315 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Tue, 16 Dec 2025 04:06:18 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.equinox.p2.ui.admin/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui.admin/META-INF/MANIFEST.MF
index 5f861766e..3c4153cc5 100644
--- a/bundles/org.eclipse.equinox.p2.ui.admin/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.ui.admin/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundleName
 Bundle-SymbolicName: org.eclipse.equinox.p2.ui.admin;singleton:=true
-Bundle-Version: 1.3.700.qualifier
+Bundle-Version: 1.3.800.qualifier
 Bundle-Activator: org.eclipse.equinox.internal.p2.ui.admin.ProvAdminUIActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Test Results

  384 files  + 10    384 suites  +10   46m 14s ⏱️ + 4m 31s
1 907 tests ±  0  1 904 ✅ +  1  3 💤 ±0  0 ❌  - 1 
6 721 runs  +128  6 712 ✅ +126  9 💤 +3  0 ❌  - 1 

Results for commit 1bf8eed. ± Comparison against base commit 6aa0d3e.

♻️ This comment has been updated with latest results.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 7 times, most recently from 2168d04 to b1bc794 Compare August 13, 2025 03:53
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 8 times, most recently from e2f1c31 to 2af9ebd Compare August 21, 2025 03:50
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 7 times, most recently from b510cee to 80fd5aa Compare August 28, 2025 03:49
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 5 times, most recently from ddfc614 to 9c2862e Compare September 2, 2025 03:44
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch from 0da09cf to e6accff Compare September 3, 2025 03:46
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires analysis

Access restriction: The method 'IProvisioningEventBus.addListener(ProvisioningListener)' is not API (restriction on classpath entry '/home/jenkins/agent/workspace/p2_PR-931/bundles/org.eclipse.equinox.p2.core/target/classes')

Imports should not matter here!

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 7 times, most recently from 260b385 to 026b610 Compare November 15, 2025 03:51
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 8 times, most recently from ac18597 to 3896faf Compare December 8, 2025 03:51
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch 7 times, most recently from 7bcf13a to 2430476 Compare December 15, 2025 03:56
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.ui.admin branch from 01f59b2 to c34883d Compare December 16, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants