GLSP-1509: Fix maven build #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use correct qualified snapshot version - Add explicit TypeAdapter for ELists to Graph JSON configurator (required due to a breaking change in GSON 2.13)
There was a problem hiding this comment.
Pull Request Overview
This PR addresses GLSP-1509 by fixing the Maven build to correctly use the qualified snapshot version and by adding an explicit TypeAdapter for ELists to the Graph JSON configurator to support changes in GSON 2.13.
- Change snapshot version qualification
- Add and register a custom TypeAdapter for ELists via InstanceCreator
Files not reviewed (19)
- examples/org.eclipse.glsp.example.workflow/META-INF/MANIFEST.MF: Language not supported
- examples/org.eclipse.glsp.example.workflow/pom.xml: Language not supported
- plugins/org.eclipse.glsp.graph/META-INF/MANIFEST.MF: Language not supported
- plugins/org.eclipse.glsp.graph/pom.xml: Language not supported
- plugins/org.eclipse.glsp.layout/META-INF/MANIFEST.MF: Language not supported
- plugins/org.eclipse.glsp.layout/pom.xml: Language not supported
- plugins/org.eclipse.glsp.server.emf/META-INF/MANIFEST.MF: Language not supported
- plugins/org.eclipse.glsp.server.emf/pom.xml: Language not supported
- plugins/org.eclipse.glsp.server.websocket/META-INF/MANIFEST.MF: Language not supported
- plugins/org.eclipse.glsp.server.websocket/pom.xml: Language not supported
- plugins/org.eclipse.glsp.server/META-INF/MANIFEST.MF: Language not supported
- plugins/org.eclipse.glsp.server/pom.xml: Language not supported
- pom.xml: Language not supported
- releng/org.eclipse.glsp.feature/feature.xml: Language not supported
- releng/org.eclipse.glsp.feature/pom.xml: Language not supported
- releng/org.eclipse.glsp.repository/pom.xml: Language not supported
- releng/pom.xml: Language not supported
- tests/org.eclipse.glsp.graph.test/pom.xml: Language not supported
- tests/org.eclipse.glsp.server.test/pom.xml: Language not supported
tortmayr
added a commit
that referenced
this pull request
Sep 13, 2025
- Use correct qualified snapshot version - Add explicit TypeAdapter for ELists to Graph JSON configurator (required due to a breaking change in GSON 2.13) Fixes eclipse-glsp/glsp/issues/1509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
P2 build uses 2.11 but m2build can pull in a higher version.
Nevertheless the fix is straight forward and prevents upgrade pains in the future so its preferrable over pinning
GSON to a version < 2.13.0
Fixes eclipse-glsp/glsp/issues/1509
How to test
Follow-ups
Changelog