Add cargo check for all features#121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 59.58% 59.58%
=======================================
Files 33 33
Lines 16071 16071
=======================================
Hits 9576 9576
Misses 6495 6495 ☔ View full report in Codecov by Sentry. |
9808b36 to
71e1b67
Compare
* Run cargo check on each feature for all bins
107d1b5 to
6c1eab6
Compare
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
|
||
| - name: "Check each feature" | ||
| working-directory: ${{github.workspace}} | ||
| run: cargo hack check --each-feature |
There was a problem hiding this comment.
It seems we run this for each platform in the build matrix, but I think we do nothing platform specific here, so maybe moving it out can save some time?
There was a problem hiding this comment.
Maybe in the (unit) test job?
There was a problem hiding this comment.
@SebastianSchildt This adds ~5m 12s runtime for the unit test action.
SebastianSchildt
left a comment
There was a problem hiding this comment.
Nice. Looking good. As for the runtime, this should also profit from the caching. We can come back if it gets too long/annoying
🏖️
This PR adds cargo-hack to build each target with all the possible feature flags.
Addresses #120