Initial DevContainer setup#128
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 60.11% 60.14% +0.03%
==========================================
Files 33 33
Lines 16191 16191
==========================================
+ Hits 9733 9738 +5
+ Misses 6458 6453 -5 ☔ View full report in Codecov by Sentry. |
af3780a to
e0a3f3d
Compare
|
@mikehaller Attention if you keep working on this locally, I did a rebase, becasue I assume the linter errors might have been due to recently merged #129 |
|
Looking good to me, just not sure we should pdate Cargo.lock in here (this PR has changed nothing in Cargo, but changing it here, might be some rebasing trouble for the next PR actually needs to change it, like probably #119 ). Opinion @lukasmittag ? |
SebastianSchildt
left a comment
There was a problem hiding this comment.
Looks good to me, shouldn't break any existing functionality. If CI agrees let's merge 🍏
A DevContainer which shows how to set up the Rust compiler and tools to make the databroker build work in vscode out of the box.
I know devcontainers are subjective and some project members may not be in favour of such a "proprietary" setup. But it will help the adoption for developers in a corporate environment :-P