-
Notifications
You must be signed in to change notification settings - Fork 22
VISS reading branches #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VISS reading branches #148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 64.06% 63.77% -0.29%
==========================================
Files 36 36
Lines 17550 17637 +87
==========================================
+ Hits 11243 11248 +5
- Misses 6307 6389 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c4eac6
to
03d76e0
Compare
e018adc
to
757ca53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
757ca53
to
6edf380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Played around with postman and send some queries, the results looked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b6e095f
to
585f944
Compare
Main modifications:
Request filter extended to support wildcard path filter operation: https://w3c.github.io/automotive/spec/VISSv2_Core.html#filter-request https://w3c.github.io/automotive/spec/VISSv2_Core.html#paths-filter-operation
Read response extended to return an array of datapoints: https://www.w3.org/TR/viss2-transport/#wss-search-read