Skip to content

VISS reading branches #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rafaeling
Copy link
Contributor

Main modifications:

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 115 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (3be386a) to head (585f944).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/viss/v2/server.rs 0.00% 113 Missing ⚠️
databroker/src/viss/v2/types.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   64.06%   63.77%   -0.29%     
==========================================
  Files          36       36              
  Lines       17550    17637      +87     
==========================================
+ Hits        11243    11248       +5     
- Misses       6307     6389      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rafaeling rafaeling force-pushed the feature/viss-reading-branches branch from 6c4eac6 to 03d76e0 Compare March 18, 2025 12:18
@rafaeling rafaeling requested a review from lukasmittag March 19, 2025 12:35
@rafaeling rafaeling force-pushed the feature/viss-reading-branches branch from e018adc to 757ca53 Compare March 19, 2025 14:08
lukasmittag
lukasmittag previously approved these changes Mar 27, 2025
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wba2hi wba2hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Played around with postman and send some queries, the results looked as expected.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag dismissed argerus’s stale review March 28, 2025 16:03

Not relevant anymore

@rafaeling rafaeling force-pushed the feature/viss-reading-branches branch from b6e095f to 585f944 Compare March 28, 2025 16:35
@rafaeling rafaeling merged commit 0985941 into eclipse-kuksa:main Mar 28, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants