Skip to content

Comments

Fix failures in CI#184

Merged
rafaeling merged 6 commits intoeclipse-kuksa:mainfrom
martinkunkel2:ci-fixes
Feb 18, 2026
Merged

Fix failures in CI#184
rafaeling merged 6 commits intoeclipse-kuksa:mainfrom
martinkunkel2:ci-fixes

Conversation

@martinkunkel2
Copy link
Contributor

Fixed multiple issues that causes the CI failures on main:

  • one link in markdown file
  • cargo clippy warnings (rust 1.93.0)
  • tokens and certificates: update from kuksa-common
  • pytest: pin version to less than 9 as workaround for a deprecated method that became an error in pytest 9

Update of certificates in kuksa-common:
eclipse-kuksa/kuksa-common#11

Signed-off-by: Martin Kunkel <git@martinkunkel.de>
Signed-off-by: Martin Kunkel <git@martinkunkel.de>
Copied from kuksa-common rev. e4c8af2

Signed-off-by: Martin Kunkel <git@martinkunkel.de>
Copied from kuksa-common rev. e4c8af2

Signed-off-by: Martin Kunkel <git@martinkunkel.de>
Signed-off-by: Martin Kunkel <git@martinkunkel.de>
pytest raises sync-test-depending-on-async-fixture which is deprecated
in pytest 8, but is an error in pytest 9.

Signed-off-by: Martin Kunkel <git@martinkunkel.de>
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.10%. Comparing base (79657b2) to head (eb519fd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/val.rs 25.00% 3 Missing ⚠️
databroker/src/vss.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   63.81%   64.10%   +0.28%     
==========================================
  Files          37       37              
  Lines       16799    16722      -77     
==========================================
- Hits        10720    10719       -1     
+ Misses       6079     6003      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmittag
Copy link
Contributor

hey @martinkunkel2 thanks for the contribution. Quick question just to check back: Whats the reason to use pytest less than version 9 is there some trouble with the newer versions?

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinkunkel2
Copy link
Contributor Author

@lukasmittag reason for the pytest version pinning is this deprecation warning:

integration_test/test_databroker.py::test_events PASSED                  [100%]

=============================== warnings summary ===============================
integration_test/test_databroker.py::test_feeder_metadata_registered
  /home/runner/work/kuksa-databroker/kuksa-databroker/.venv/lib/python3.12/site-packages/_pytest/fixtures.py:1182: PytestRemovedIn9Warning: 'test_feeder_metadata_registered' requested an async fixture 'setup_helper', with no plugin or hook that handled it. This is usually an error, as pytest does not natively support it. This will turn into an error in pytest 9.
  See: https://docs.pytest.org/en/stable/deprecations.html#sync-test-depending-on-async-fixture

without the version pinning, pytest 9 is used which fails.

@martinkunkel2
Copy link
Contributor Author

@lukasmittag : if possible, please also review eclipse-kuksa/kuksa-common#11. So that the certificates files in this repo and kuksa-common are in sync.

@martinkunkel2
Copy link
Contributor Author

@lukasmittag Thank you for merging eclipse-kuksa/kuksa-common#11.
The certificates are the same on this PR. Can this PR also be merged?

@rafaeling rafaeling merged commit 2936b25 into eclipse-kuksa:main Feb 18, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants