Skip to content

Conversation

@lukasmittag
Copy link
Contributor

This modifies as well the generation of the files from submodules. Needs to be checked if this works as well for the pypi package or if we need to change back.

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace submodule URL. If CI pass ok to merge

@lukasmittag lukasmittag requested a review from erikbosch October 1, 2024 14:03

To use the right api interfaces of databroker run the following:
```console
python3 -m proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I am thinking if we should add

proto/**/*.py

to the .gitignore of kuksa-databroker so that the submodule isn't reported as dirty after this command

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, if you change the two infoto debug I am happy

(alternatively keep them as info but add a TODO comment that they longterm shall be debug)

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag lukasmittag merged commit ce689a3 into eclipse-kuksa:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants