Skip to content

fix: generic error when setting access point with no password #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMaiero merged 4 commits into from
Oct 22, 2025
Merged

fix: generic error when setting access point with no password #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64cf164
fix: removed placeholder for empty passwords
sfiorani Oct 20, 2025
2897ee1
fix: added fix for none security
sfiorani Oct 21, 2025
036e04d
refactor: implemented a more simple solution
sfiorani Oct 22, 2025
8aec893
fix: mandatory conditional validation
sfiorani Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/TabWirelessUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ private void initForm() {
});

this.password.addBlurHandler(e -> this.password.validate());
this.password.setAllowBlank(false);
this.password.setAllowBlank(true);
this.password.addMouseOutHandler(event -> resetHelp());

this.buttonPassword.addClickHandler(event -> {
Expand Down Expand Up @@ -1300,6 +1300,8 @@ private void setPasswordValidation() {
this.password.setValidatorsFrom(Optional.empty(), passwordStrengthRequirements);
this.password
.addValidator(GwtValidators.regex(REGEX_PASS_WEP, MSGS.netWifiWirelessInvalidWEPPassword()));
} else if (this.security != null && this.security.getSelectedItemText().equals(WIFI_SECURITY_NONE_MESSAGE)) {
this.password.setValidators();
} else {
passwordStrengthRequirements.allowAnyPassword();
this.password.setValidatorsFrom(Optional.empty(), passwordStrengthRequirements);
Expand Down Expand Up @@ -1716,6 +1718,7 @@ private boolean checkPassword() {
this.groupPassword.setValidationState(ValidationState.ERROR);
result = false;
} else {
TabWirelessUi.this.helpPassword.setText("");
this.groupPassword.setValidationState(ValidationState.NONE);
}

Expand Down
5 changes: 4 additions & 1 deletion ...ipse/kura/web/server/net2/configuration/NetworkConfigurationServicePropertiesBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.eclipse.kura.web.shared.model.GwtNetRouterMode;
import org.eclipse.kura.web.shared.model.GwtWifiConfig;
import org.eclipse.kura.web.shared.model.GwtWifiNetInterfaceConfig;
import org.eclipse.kura.web.shared.model.GwtWifiSecurity;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -234,7 +235,9 @@ private void setWifiMasterProperties() throws GwtKuraException {

this.properties.setWifiMasterPassphrase(this.ifname, gwtApConfig.getPassword());
} else {
GwtServerUtil.validateUserPassword(Optional.empty(), gwtWifiConfig.getPassword());
if (!gwtWifiConfig.getSecurity().equals(GwtWifiSecurity.netWifiSecurityNONE.name())) {
GwtServerUtil.validateUserPassword(Optional.empty(), gwtWifiConfig.getPassword());
}
this.properties.setWifiMasterPassphrase(this.ifname, gwtWifiConfig.getPassword());
}
}
Expand Down
9 changes: 6 additions & 3 deletions ...s/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/util/GwtServerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,16 +771,19 @@ public static List<GwtNetInterfaceConfig> replaceNetworkConfigListSensitivePassw
if (netConfig instanceof GwtWifiNetInterfaceConfig) {
GwtWifiNetInterfaceConfig wifiConfig = (GwtWifiNetInterfaceConfig) netConfig;
GwtWifiConfig gwtAPWifiConfig = wifiConfig.getAccessPointWifiConfig();
if (gwtAPWifiConfig != null) {
if (gwtAPWifiConfig != null && gwtAPWifiConfig.getPassword() != null
&& !gwtAPWifiConfig.getPassword().isEmpty()) {
gwtAPWifiConfig.setPassword(PASSWORD_PLACEHOLDER);
}

GwtWifiConfig gwtStationWifiConfig = wifiConfig.getStationWifiConfig();
if (gwtStationWifiConfig != null) {
if (gwtStationWifiConfig != null && gwtStationWifiConfig.getPassword() != null
&& !gwtStationWifiConfig.getPassword().isEmpty()) {
gwtStationWifiConfig.setPassword(PASSWORD_PLACEHOLDER);
}
Gwt8021xConfig gwt8021xConfig = wifiConfig.get8021xConfig();
if (gwt8021xConfig != null) {
if (gwt8021xConfig != null && gwt8021xConfig.getPassword() != null
&& !gwt8021xConfig.getPassword().isEmpty()) {
gwt8021xConfig.setPassword(PASSWORD_PLACEHOLDER);
}

Expand Down