test: Improved CloudConnectionEndpointsTest [backport release-5.6.0]#6186
Merged
nicolatimeus merged 2 commits intorelease-5.6.0from Feb 23, 2026
Merged
test: Improved CloudConnectionEndpointsTest [backport release-5.6.0]#6186nicolatimeus merged 2 commits intorelease-5.6.0from
nicolatimeus merged 2 commits intorelease-5.6.0from
Conversation
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
nicolatimeus
changed the title
| @@ -25,4 +25,5 @@ Import-Package: com.google.gson;version="2.9.0", | |||
| Fragment-Host: org.eclipse.kura.rest.cloudconnection.provider | |||
| Require-Bundle: org.eclipse.kura.http.server.manager;bundle-version="1.1.0", | |||
| org.eclipse.kura.broker.artemis.core;bundle-version="1.2.0", | |||
Member
There was a problem hiding this comment.
I would remove the version near the bundles to rely on the ones build in the reactor. Sometime it is source of problems if the packages version are updated
|
|
||
| givenUpdateComponentConfigurationRequest(UPDATE_COMPONENT_CONFIGURATION_REQUEST); | ||
| givenUpdateComponentConfigurationRequest("{" + // | ||
| "\"configs\": [" + // |
Member
There was a problem hiding this comment.
To improve maintainability, I'd move the configuration request to an external file.
Member
Author
There was a problem hiding this comment.
I've put them inline to be able to add pass some dynamic parameters in the requests
salvatore-coppola
previously approved these changes
Feb 23, 2026
salvatore-coppola
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]shouldConnectEndpoint()does not rely anymore on the configuration step performed byshouldUpdateStackComponentConfigurations()shouldGetStackComponentPids()no longer fails depending on the order of the component pids returned by the server