feat: Implement FileBasedAgentRegistryService #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new implementation of AgentRegistryService, `FileBasedAgentRegistryService`, which reads agent routing information from a YAML file. Key changes: - Added `FileBasedAgentRegistryService` in `lmos-runtime-core` that parses an `agent-registry.yaml` file. - Introduced configuration properties in `lmos-runtime-spring-boot-starter` to switch between `API` and `FILE` based registry types (lmos.runtime.agent-registry.type) and to specify the YAML file path (lmos.runtime.agent-registry.file-path). - Updated `LmosRuntimeAutoConfiguration` to conditionally instantiate the configured `AgentRegistryService` implementation. - Refactored agent registry data models to a common location in `lmos-runtime-core.model.registry` and made necessary adjustments for YAML deserialization (e.g., nullable fields). - Added `kaml` library for YAML parsing in `lmos-runtime-core`. - Implemented comprehensive unit tests for `FileBasedAgentRegistryService` in `lmos-runtime-core`. - Implemented integration tests in `lmos-runtime-spring-boot-starter` to verify the correct service instantiation and functionality within the Spring context. The choice of `AgentRegistryService` is now configurable via properties: - `lmos.runtime.agent-registry.type`: Set to `FILE` to use the new service, or `API` (default) for the existing LMOS Operator based service. - `lmos.runtime.agent-registry.file-path`: Specifies the path to the `agent-registry.yaml` file when type is `FILE`. The `lmos-runtime-core` and `lmos-runtime-spring-boot-starter` modules build and pass all their tests. An unrelated issue with Helm setup was noted in the `lmos-runtime-graphql-service` module but does not affect this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new implementation of AgentRegistryService,
FileBasedAgentRegistryService, which reads agent routing information from a YAML file.Key changes:
FileBasedAgentRegistryServiceinlmos-runtime-corethat parses anagent-registry.yamlfile.lmos-runtime-spring-boot-starterto switch betweenAPIandFILEbased registry types (lmos.runtime.agent-registry.type) and to specify the YAML file path (lmos.runtime.agent-registry.file-path).LmosRuntimeAutoConfigurationto conditionally instantiate the configuredAgentRegistryServiceimplementation.lmos-runtime-core.model.registryand made necessary adjustments for YAML deserialization (e.g., nullable fields).kamllibrary for YAML parsing inlmos-runtime-core.FileBasedAgentRegistryServiceinlmos-runtime-core.lmos-runtime-spring-boot-starterto verify the correct service instantiation and functionality within the Spring context.The choice of
AgentRegistryServiceis now configurable via properties:lmos.runtime.agent-registry.type: Set toFILEto use the new service, orAPI(default) for the existing LMOS Operator based service.lmos.runtime.agent-registry.file-path: Specifies the path to theagent-registry.yamlfile when type isFILE.The
lmos-runtime-coreandlmos-runtime-spring-boot-startermodules build and pass all their tests. An unrelated issue with Helm setup was noted in thelmos-runtime-graphql-servicemodule but does not affect this feature.