refact: use TextPresentation#mergeStyles instead of hand-written merge #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As suggested in #1221 (comment) |
|
I didn't test it but code looks good enough to me. Assuming you have verified that the underline doesn't remove other styles, let's then merge. |
|
I did not verify it, I assumed that the tests where covering it, as this was part of the comments on the previous PR. I do not have time to do manual testing, so if you are not sure, I would rather drop the PR. |
|
I'm not sure whether it's covered by tests or not. I think at this stage, let's keep the PR open until someone can verify it and whenever it's confirmed to be working as expected we'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.